Register PicoLume for PIDs 2008 and 2009#1140
Open
bradhenson wants to merge 2 commits intopidcodes:masterfrom
Open
Register PicoLume for PIDs 2008 and 2009#1140bradhenson wants to merge 2 commits intopidcodes:masterfrom
bradhenson wants to merge 2 commits intopidcodes:masterfrom
Conversation
tannewt
requested changes
Feb 5, 2026
Collaborator
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Kicad source and C++ sources look good. I'd recommend getting two pids. One for each device. It'll make it your life easier by being able to distinguish the two.
Split single PID registration into two: 0x2008 for the PicoLume Receiver and 0x2009 for the PicoLume Remote, as recommended by maintainer review.
bradhenson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers the PicoLume project under VID 0x1209 with two PIDs:
Project page: https://picolume.com/
Source: https://github.com/picolume/
Licensed under GPLv3 (firmware) and MIT (hardware).
Updated per maintainer feedback to use separate PIDs for each device.